Discussion:
[MCollective - Feature #6865] (Unreviewed) Proposed patch to add support to puppetd agent extra command line args
(too old to reply)
t***@puppetlabs.com
2011-03-28 04:12:43 UTC
Permalink
Issue #6865 has been reported by Mohamed Lrhazi.

----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Unreviewed
Priority: Normal
Assignee:
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-03-28 21:46:38 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.

Project changed from MCollective to MCollective Plugins


----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Unreviewed
Priority: Normal
Assignee:
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-03-28 21:52:56 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.

Status changed from Unreviewed to Accepted
Assignee set to R.I. Pienaar


----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Accepted
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-03-30 23:50:40 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


This change actually makes mc-puppetd very dangerous...
In our setup, we have all machines configured to run with noop=true, set to a specific environment and set to speak to a production puppetmaster. machines are setup so we can also make them speak to a puppet-test server, when need be.

Changes to the production puppetmaster are carefully reviewed, and so are changes to the modules in those specific 'production environments'.

With this feature in mc-puppetd, one could bypass all the restrictions and force all machines to run against the test puppetmaster, requesting an untested environment:

mc-puppetd --options "--environment my_beta_env --server puppet-test.dom.ain --no-noop" runall 5


I think "--options" is still very useful, and we will use it in our production env... Just thought I'd point that danger out. I was thinking about maybe adding logic to mc-puppetd to refuse to run in certain circumstances.. say if number of affected hosts is above a threshold and the --environment or --server options are included.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Accepted
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-03-31 19:29:44 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


There is a bug in the ddl, cause mc-puppetd to fail if --options is not supplied.


@@ -31,7 +31,7 @@
:prompt => "Puppetd options",
:description => "Extra command line arguments to puppetd",
:type => :string,
- :validation => '^.+$',
+ :validation => '^.*$',
:optional => true,
:maxlength => 256

----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Accepted
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 15:48:28 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.

Status changed from Accepted to Needs Decision

I am putting this to 'needs decision' as I am still undecided how I feel about this patch, as demonstrated on the list recently it can expose some unexpected behavior that is sub optimal for the user.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 18:06:02 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


Would a compromise be to add a notification/confirmation promopt when a problematic option is passed? maybe only --no-daemonize and --waitforcert would be an issue?

----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 18:09:43 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.
Post by t***@puppetlabs.com
Would a compromise be to add a notification/confirmation promopt when a problematic option is passed? maybe only --no-daemonize and --waitforcert would be an issue?
How would you define a problematic argument? I mean this could be seen as a HUGE security risk, imagine you give someone non root shell level access to a server and access to mcollective. Safe right? Nope, cos they can start puppetd as root via mcollective passing into it a custom manifest dir where they can run any .pp files it finds in random directories.

The work to determine whats safe and not would be epic, every config option in puppet.conf is also a command line option and these change frequently as puppet add more features, we'd forever be playing catchup.

It really is the same concerns I have with a plugin that can run random shell commands, just not the mcollective way of doing things.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 18:16:36 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


By "problematic" I was simply thinking in terms of mcollective expecting commands to finish in under the default 3 seconds timeout. I kind of forgo about other implications....

Ok.. How about a config parameter that the user can use to set exactly what options are allowed? "allowed_options", which would default to what we consider to be safe, maybe just "noop" "no-noop", and then leave it up to the user to decide beyond that what risks they are willing to take?
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 18:27:51 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.


That would probably be good, best would be to just add boolean options to enable noop if thats what you want though. Then the API interface is strictly defined and ppl know what to expect
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 18:40:49 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


am not sure I understand. Are you saying you would be willing to accept --options, if it came with an "allowed_options" config setting? or you would rather see two additional boolean options only, --noop and no-noop?

In our site, I'd say that we cannot live without noop/no-noop, and would be happy to have the option of additional "options" if we ever needed them someday: --server/--tags/--environment...

mcollective can affect systems that are unreachable via SSH, say due to LDAP issue, like we had recently after some ssl certs were updated on the LDAP servers... so it could act as an "out-of-band" path to access and fix some problem that would otherwise require console access to each and every system... So, there might be cases where the ability to run puppetd in an "unexpected" way, might be useful.

Thanks a lot.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 20:35:39 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.
Post by t***@puppetlabs.com
am not sure I understand. Are you saying you would be willing to accept --options, if it came with an "allowed_options" config setting? or you would rather see two additional boolean options only, --noop and no-noop?
I am saying with a whitelist of option - not a blacklist - I think its safe, but first price would be passable boolean options.
Post by t***@puppetlabs.com
mcollective can affect systems that are unreachable via SSH, say due to LDAP issue, like we had recently after some ssl certs were updated on the LDAP servers... so it could act as an "out-of-band" path to access and fix some problem that would otherwise require console access to each and every system... So, there might be cases where the ability to run puppetd in an "unexpected" way, might be useful.
that's true, if you want to hack on the whitelist as described I think that will address my concerns

----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-04 23:48:20 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


Please consider the updated version (branch puppetd_options): https://github.com/lrhazi/mcollective-plugins

Have not heavily tested the security point of view, but tried to think about it a bit.
Should be easy to improve/fix bugs, by updating the regexes...

Thanks a lot.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Needs Decision
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-11 15:22:49 UTC
Permalink
Issue #6865 has been updated by R.I. Pienaar.

Status changed from Needs Decision to Code Insufficient

Thanks for this,

Sorry to be a pain, but your commit puts the whitelist on the client side in the mc-puppetd script. This doesnt actually provide any security it just means for that single script there's a roadblock, someone can still use mco rpc or just in ruby to call the agent and bypass your restrictions.

the security - the whitelist - has to be in the agent to be effective.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-11 18:31:12 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


Nah, my bad. Will work on this tonight. Thanks.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-13 01:04:33 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


I moved the puppetd options checks from clients to server side. Please check my latest commit https://github.com/lrhazi/mcollective-plugins/tree/puppetd_options
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-13 01:08:22 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


I still think that safer would be to bypass the shell altogether by using IO.popen. I am not comfortable yet with Ruby, nor with mcollective, to try and code that.

http://ruby-doc.org/core/classes/IO.html#M000880

cmd:
"-" : fork
commandline : command line string which is passed to a shell
[env, cmdname, arg1, ..., opts] : command name and zero or more arguments (no shell)
[env, [cmdname, argv0], arg1, ..., opts] : command name, argv[0] and zero or more arguments (no shell)
(env and opts are optional.)
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-13 17:38:18 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


Overriding the default white-list from the plugin options does not seem to work. I will update this ticket when I resolved it.
Thanks.
----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
t***@puppetlabs.com
2011-04-13 18:08:00 UTC
Permalink
Issue #6865 has been updated by Mohamed Lrhazi.


I think I figured it out. It seems this is wrong:

plugin.puppetd.options_whitelist = "--noop,--no-noop,--tags,--environment"

While this is correct:

plugin.puppetd.options_whitelist = --noop,--no-noop,--tags,--environment

----------------------------------------
Feature #6865: Proposed patch to add support to puppetd agent extra command line args
https://projects.puppetlabs.com/issues/6865

Author: Mohamed Lrhazi
Status: Code Insufficient
Priority: Normal
Assignee: R.I. Pienaar
Category:
Target version:
Keywords:
Branch:
Affected mCollective version:


I am suggesting a patch for puppetd agent, which allows the user to pass arbitrary command line arguments to be passed to puppetd.

Please the forked here, branch name: puppetd_options

https://github.com/lrhazi/mcollective-plugins

Thanks.
--
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To post to this group, send email to puppet-***@googlegroups.com.
To unsubscribe from this group, send email to puppet-bugs+***@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
Loading...